My paladin is a Jewelcrafter. This expansion was very weird for that profession.
On the demand-side, sockets became part of titan-forging. There's a small chance that any piece of gear drops with a socket on it. But it's pretty rare. I think I have one piece (other than my crafted ring) with a socket at the moment. So not very many people were buying gems this expansion.
On the supply-side, jewelcrafters were flooded with gems. The number of raw materials gained per unit of ore was very high, much higher than in previous expansions. I think I have over 100 of each rare gem in my inventory, just left over from crafting the rings.
That combination of low demand and high supply drove gem prices very low, and made the profession very disappointing.
For solutions, on the demand-side, I would have liked to see a socket be the "first level" of titan-forging. If a piece of gear titan-forges, it always gets a socket. It may get additional bonuses after, but it starts with a socket. This would make the demand for gems higher and more consistent. In addition, it would also smooth out the power of titan-forging. Socketed pieces were generally considered better than 10-15 extra item levels.
Another idea is to allow jewelcrafters (or maybe blacksmiths) to make an item which adds a socket to a weapon. Like Ramaladni's Gift from Diablo 3. This would also make it a little easier to use the main stat gems for hybrid classes, as weapons don't often share primary stats in endgame.
On the supply-side, simply produce less raw materials per ore. Also instead of having special colors that weren't used for stat gems, have those recipes use two or more regular gems.
Jewelcrafting in Battle For Azeroth was a disappointing profession. Let's hope that Shadowlands makes it more useful.